GCI1066 [Team TREE][2025] - Logging format interpolation #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NETOIK
changed the title
NETOIK
changed the title
MP-Aubay
changed the title
MP-Aubay
requested changes
May 21, 2025
jycr
reviewed
May 21, 2025
MP-Aubay
requested changes
May 21, 2025
dedece35
requested changes
Jun 14, 2025
| @@ -0,0 +1,51 @@ | |||
| When logging with formatted string, prefer using `%s` and logging kwargs which will be deferred until it cannot be avoided, instead of immediate `.format()` of `f""` interpolation. | |||
There was a problem hiding this comment.
Could you add a new test with codeCarbon to check these to uses cases :
- one use case where "debug" mode is enabled
- one use case where "debug" mode is disabled
|
This PR has been automatically marked as stale because it has no activity for 60 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rule GCI1066: For logging format, prefer using
%swith kwargs instead of builtin formatter"".format()orf"", that way message formatting will be deferred until it cannot be avoided.References:
python doc about logging optimization
warning raised by pylint